One problem I just realized - and we indeed have that problem already - is that when a sub-system maintainer AND a code gardener are working on a patch, they will have hard times to find someone for peer-reviews, because already two people of a very small group of people being able to do quality reviews basically cannot really sign off that patch.

Additionally, there is very likely a too high trust-level for any peer-reviewers in the game - because both a sub-system maintainer and code gardener worked on a patch - so how bad and wrong can it really be...? :-/

Hence, that is clearly the scenario where a patch may only get peer-reviews from people that worked on the patch, and core branch maintainers may be involved too early.

Not really sure whether that is really an edge-case scenario or perhaps even happens way too often.

Reply

The content of this field is kept private and will not be shown publicly.
  • Allowed HTML tags: <a> <blockquote> <em> <strong> <u> <cite> <code> <ul> <ol> <li> <dl> <dt> <dd> <div>
  • Web page addresses and e-mail addresses turn into links automatically.
  • Lines and paragraphs break automatically.

More information about formatting options

By submitting this form, you accept the Mollom privacy policy.